This repository was archived by the owner on Sep 8, 2025. It is now read-only.
Closed
Conversation
We were using the Bitcoin format when encoding signatures, with the recovery id (v) at the first byte. Also change decode_public_key() to accept only 64-bytes long public keys and encode_raw_public_key() to generate the 64-bytes version as well (without the \x04 prefix) as that's what we must use when generating addresses.
pacrob
pushed a commit
to pacrob/py-evm
that referenced
this pull request
Dec 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to see the diff!